Use semibold instead of bold for UI labels in Docs#3465
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiewatson1973
changed the title
jamiewatson1973
changed the title
Mirrors the equivalent change in ably/website (packages/ui, PR #9079). This repo carries its own vendored copy of the design system plus a few docs-specific components (LeftSidebar section headings, examples list) that use the same label typography scale with a bold override. ProductLabel's identity lockup (the "COMING SOON"/"Ably" wordmark badge and product name) is left bold intentionally.
m-hulbert
force-pushed
the
claude/ui-label-weight-docs
branch
from
ee4b22c to
6c413d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mirrors ably/website#9079 (
packages/ui), which changed button, menu, and label typography fromfont-boldtofont-semibold. This repo carries its own vendored copy of that design system, plus a few docs-specific components built on the same label typography scale (ui-text-labelN).Changed:
src/styles/ui/core/styles/buttons.css— all 4 label-scale button sizessrc/components/ui/TabMenu.tsx— tab menu triggersrc/components/ui/FeaturedLink.tsx— featured link textsrc/components/ui/CodeSnippet.tsx— code-window title barsrc/components/Layout/LeftSidebar.tsx— section heading class, and a duplicated inline instance of the same stylesrc/components/Examples/ExamplesList.tsx— examples-list filter linkLeft alone intentionally:
src/components/ui/ProductTile/ProductLabel.tsx— the "COMING SOON"/"Ably" wordmark identity lockup and product name stay bold.Checklist
Generated by Claude Code